I found some motivation/energy to work on private-wiki recently. Part of that project requires having some sort of text editor. I decided to play around with react-quill. After spending some time getting it setup in build.sbt and creating a scalajs-react wrapper (future blog post?), I was able to see the editor in the UI. Unfortunately, there was an error in the browser console. The issue has been fixed, but it’s not in the latest release (0.2.1). Annoying, but UI seems to work, so not a huge deal. Except that logging a console error in PhantomJS blows up. That means I can’t run tests in PhantomJS.
After reading the issue and the couple of issues linked to it, I decided to run the tests in a real browser instead. japgolly has put together an awesome tutorial on how to do this. His sbt files lets you do
firefox:test, which runs the tests in Firefox. However, I’m not a huge fan of copying every single config key from the
Test config. If there is a new one added at some point, I probably won’t notice it. My goal was to try to copy the
Test config as much as possible without actually copying every single key manually. After hacking at sbt for a bit, I came up with the solution below.
Warning: I had to try a few different variations in sbt before I got something that worked. I tried a few that I thought would have worked, but didn’t. I think the solution I came up with works, but I obviously don’t understand sbt, so I may be missing something fundamental. If you know sbt and think the following is wrong, please let me know.
Add the following to
libraryDependencies += "org.scala-js" %% "scalajs-env-selenium" % "0.1.2"
build.sbt, add the following:
lazy val FirefoxTest = config("firefox") extend Test lazy val ChromeTest = config("chrome") extend Test
In the client project, add:
client .configs(FirefoxTest, ChromeTest) .settings( inConfig(FirefoxTest)(Defaults.testTasks) : _*) .settings( inConfig(FirefoxTest)(ScalaJSPluginInternal.scalaJSTestSettings) : _*) .settings( inConfig(ChromeTest)(Defaults.testTasks) : _*) .settings( inConfig(ChromeTest)(ScalaJSPluginInternal.scalaJSTestSettings) : _*) .settings( inConfig(FirefoxTest)( jsEnv := new org.scalajs.jsenv.selenium.SeleniumJSEnv(org.scalajs.jsenv.selenium.Firefox))) .settings( inConfig(ChromeTest)( jsEnv := new org.scalajs.jsenv.selenium.SeleniumJSEnv(org.scalajs.jsenv.selenium.Chrome)))
If you’re using Travis CI, add the following to
before_script: - "export DISPLAY=:99.0" - "sh -e /etc/init.d/xvfb start" - sleep 3 # give xvfb some time to start
Make sure to prefix the client tests with
script. You’ll get something like:
script: - sbt ++$TRAVIS_SCALA_VERSION 'clean' 'set scalaJSStage in Global := FastOptStage' "client/firefox:test" - sbt ++$TRAVIS_SCALA_VERSION 'clean' 'set scalaJSStage in Global := FullOptStage' "client/firefox:test" - sbt ++$TRAVIS_SCALA_VERSION "server/test"
There are a few problems with the above. In no particular order:
- I’m not sure how much time Travis should be sleeping after starting Xvfb. I got the 3 seconds from their docs. A shorter time might work, but 3 seconds isn’t too much compared to how long the build takes, so I’m not too worried.
- Running tests in Firefox is slower than PhantomJS. I haven’t actually measured it, but it felt noticeably slower. That may be because I couldn’t do anything else while Firefox was starting up and taking over the screen.
- Can’t run headless tests on Macs. japgolly mentions using Xvfb for headless testing. I’ve used it at work on Linux successfully as well. At home, I’m working on a Mac, and firefox-x11 is unavailable in brew. It was available in macports for a bit, but it’s no longer maintained. Having Firefox keep flashing on my screen is going to get annoying, so I’ll have to pursue some options. Main idea so far is to run the tests in Docker. If I get that working, I’ll write another blog post.
- No Chrome in Travis CI. I was going to do this, but then noticed this issue in scala-js-env-selenium. I’d like to run tests in Chrome in Travis CI at some point though. Maybe use Docker for that too?
- Failing tests don’t actually fail. I wrote a failing test, but ScalaTest didn’t report the error to sbt, so the build passed. For private-wiki, this only happened in Chrome. When I tried to minimally reproduce it, it failed to fail in both Firefox and Chrome. Bizarre and a bit worrying.